No internet connection
  1. Home
  2. Issues

Dark mode fix?

By Boris Giba @BorisGiba
    2020-10-02 16:58:29.893Z

    Hey, it's me again.

    So I setup TalkYard on my Website and it works really well. I added the dark style-css you posted here:

    and looking at the page works great. However, when adding a comment or hovering over icons it still is white (see image). I could not edit the css of the editor field. So f.e. if I try to change the style of "#editor-after-borders" it does nothing.
    I looked at the roadmap and saw that themeing has been a point on that. I know you have a lot of work to do, so I just wanted to ask, if there is some documentation available for the element names and/or when you plan to tackle themeing (this year still?). Dark mode would be pretty important for me since my website is mostly dark, so I really appreciate any feedback you can give.
    Again, I know you probably have lots of work, so no pressure, I just want to be able to plan a little bit.

    Reply
    • 6 replies
    1. KajMagnus @KajMagnus2020-10-04 09:47:44.111Z

      I think I can fix the editor CSS, in a new version, this week or next week. Thereafter, making a dark themed editor should work. (Seems like just a <style ...> tag I forgot to include in the editor <iframe>.)

      I'll have a look at the hover-over-icons white color thing.

      (Documentation: Not yet, not more than in the "Changing the colors" topic you found.
      Theming: Now finishing OIDC, then, tags & Slack & Mattermost integration, then maybe theming.
      I think, though, that once the custom CSS works in the editor too, that's all that's needed — just that writing custom CSS is harder.)

      Reply
      1. BBoris Giba @BorisGiba
          2020-10-05 16:30:54.587Z

          Ok, thank you for the reply! Let me (or us, I'll keep track of the forum) know when the CSS is working in the editor.

          Reply
          1. KajMagnus @KajMagnus2020-10-07 19:58:04.668Z

            Probably on Friday, about to fix now

            Reply
            1. KajMagnus @KajMagnus2020-10-11 15:08:41.279Z

              Hi @BorisGiba now the CSS styles work also inside the editor (if you're hosted at Ty .net — I'll bump the self hosted version tomorrow or on Tuesday).

              I added this sample code section: /* Embedded blog comments editor (it's in its own <iframe> ) at the end of the Changing the colors dark theme reply.

              Reply1 Like
              1. BBoris Giba @BorisGiba
                  2020-10-22 08:45:33.844Z

                  Thank you!!
                  It works like a charm :)

                  Reply1 Like
                  1. KajMagnus @KajMagnus2020-10-22 11:04:27.582Z

                    Ok, I'll close this topic for now then? Feel free to reopen if there's somethign more

                    Reply
          2. Progress
            with handling this problem
          3. @KajMagnus marked this topic as Planned 2020-10-04 09:47:54.744Z.
          4. @KajMagnus marked this topic as Done 2020-10-22 11:04:36.995Z.
          Reply (discussion)Add progress note